[W3W, Sign] X-Platform e2e protocol test - session settle #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V2 into E2E-tests # Conflicts: # Example/ExampleApp.xcodeproj/project.pbxproj # Sources/WalletConnectEcho/EchoClientFactory.swift
…V2 into E2E-tests # Conflicts: # Sources/Web3Inbox/Web3InboxClientFactory.swift
radeknovis
reviewed
Aug 10, 2023
| } | ||
|
|
||
| if jsSession == nil { | ||
| sleep(1) |
There was a problem hiding this comment.
This is ok for now, but in future, if we are going to have more tests using the JS API, can they implement something like long polling?
There was a problem hiding this comment.
👍 good idea, 100%, will speak with js team
radeknovis
approved these changes
Aug 10, 2023
…V2 into E2E-tests # Conflicts: # Configuration.xcconfig # Example/ExampleApp.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
passed tests - https://github.com/WalletConnect/WalletConnectSwiftV2/actions/runs/5795589196
Resolves # (issue)
How Has This Been Tested?
Due Dilligence