Native Redirect #1202
Merged
Native Redirect #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
flypaper0
reviewed
Oct 30, 2023
|
|
||
| public struct WalletConnectRouter { | ||
| public static func goBack(uri: String) { | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
do we nee separate package to call UIApplication.shared.open?
May be just remove Router package?
There was a problem hiding this comment.
I want to keep the old solution to maintain functionality for iOS versions below 17 and to be prepared for any potential future workarounds
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
llbartekll
reviewed
Oct 30, 2023
| import UIKit | ||
|
|
||
| public struct WalletConnectRouter { | ||
| public static func goBack(uri: String) { |
There was a problem hiding this comment.
what happens if the uri is an empty string for example?
should the function throw?
| /* Redirect */ | ||
| let session = getSession(topic: sessionRequest.topic) | ||
| if let uri = session?.peer.redirect.native { | ||
| WalletConnectRouter.goBack(uri: uri) |
There was a problem hiding this comment.
how do you distinguish new router from the legacy one here?
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
llbartekll
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence