Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychain group migration #1243

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Keychain group migration #1243

merged 13 commits into from
Dec 1, 2023

Conversation

llbartekll
Copy link
Contributor

Description

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

…ect/WalletConnectSwiftV2 into keychain-group-migration

# Conflicts:
#	Sources/Auth/AuthClientFactory.swift
#	Sources/WalletConnectNetworking/NetworkingClientFactory.swift
#	Sources/WalletConnectPairing/PairingClientFactory.swift
#	Sources/WalletConnectPush/PushClientFactory.swift
#	Sources/WalletConnectRelay/RelayClientFactory.swift
#	Sources/WalletConnectSign/Sign/SignClientFactory.swift
Copy link
Contributor

@flypaper0 flypaper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge 👍

@llbartekll llbartekll merged commit 3867a65 into develop Dec 1, 2023
8 checks passed
@llbartekll llbartekll deleted the keychain-group-migration branch December 1, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants