chore(rejection tags): Session rejection tags #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
reviewed
May 29, 2024
Sources/WalletConnectSign/Types/ProtocolMethods/SessionProposeProtocolMethod.swift
Show resolved
Hide resolved
Sources/WalletConnectSign/Types/ProtocolMethods/SessionProposeProtocolMethod.swift
Show resolved
Hide resolved
Sources/WalletConnectSign/Auth/Services/App/SessionAuthRequestService.swift
Show resolved
Hide resolved
Sources/WalletConnectSign/Auth/Services/Wallet/AuthRequestSubscriber.swift
Show resolved
Hide resolved
Sources/WalletConnectSign/Auth/Services/Wallet/AuthRequestSubscriber.swift
Show resolved
Hide resolved
jackpooleywc
force-pushed
the
jack/rejection-tags
branch
from
e739136
to
16aacba
Compare
llbartekll
approved these changes
Jun 3, 2024
jackpooleywc
force-pushed
the
jack/rejection-tags
branch
from
16aacba
to
aee6e31
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds specific rejection tags for
sessionProposeandsessionAuthenticateto disambiguate user rejection from genuine failures.How Has This Been Tested?
This will be manually tested.