#207 Update namespaces #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 12, 2022 11:26
llbartekll
approved these changes
May 17, 2022
| @@ -5,8 +5,7 @@ import WalletConnectKMS | |||
| import Combine | |||
|
|
|||
| final class ControllerSessionStateMachine: SessionStateMachineValidating { | |||
| var onAccountsUpdate: ((String, Set<Account>)->())? | |||
| var onNamespacesUpdate: ((String, Set<Namespace>)->())? | |||
| var onNamespacesUpdate: ((String, [String: SessionNamespace])->())? | |||
| var onExpiryUpdate: ((String, Date)->())? | |||
There was a problem hiding this comment.
we could rename that callback to onExtend to not use expiry update any more
| @@ -69,17 +69,17 @@ final class PairingEngine { | |||
| return uri | |||
| } | |||
|
|
|||
| func propose(pairingTopic: String, namespaces: Set<Namespace>, relay: RelayProtocolOptions) async throws { | |||
| func propose(pairingTopic: String, namespaces: [String: ProposalNamespace], relay: RelayProtocolOptions) async throws { | |||
There was a problem hiding this comment.
what do you think of having a ProposalNamespaces typealias for [String: ProposalNamespace] ?
| case .sessionUpdateExpiry: | ||
| case .sessionUpdate: | ||
| handleUpdateResponse(topic: response.topic, result: response.result) | ||
| case .sessionExtend: | ||
| handleUpdateExpiryResponse(topic: response.topic, result: response.result) |
| @@ -6,8 +6,7 @@ import Combine | |||
|
|
|||
| final class NonControllerSessionStateMachine: SessionStateMachineValidating { | |||
|
|
|||
| var onAccountsUpdate: ((String, Set<Account>)->())? | |||
| var onNamespacesUpdate: ((String, Set<Namespace>)->())? | |||
| var onNamespacesUpdate: ((String, [String: SessionNamespace])->())? | |||
| var onExpiryUpdate: ((String, Date) -> ())? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #207, closes #202
Refactors the client to work with the new namespace spec. Does not implement validation yet.
updateAccountmethod.updateExpiryback toextendTemporary changes:
Namespace validation will be done in next PR.