Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApproveEngine async calls #270

Merged
merged 6 commits into from
Jun 15, 2022
Merged

ApproveEngine async calls #270

merged 6 commits into from
Jun 15, 2022

Conversation

flypaper0
Copy link
Contributor

What changed?

Sample app
Approve / Reject calls wrapped in Tasks. Errors handled by logger

SDK

  • Async Approve and Reject methods
  • NetworkInteractor: Async RespondError and RespondSuccess methods
  • Dispatcher: Async Send method
  • Async callbacks for wcRequestPublisher subscribers
  • Respond Namespace validation errors

@flypaper0 flypaper0 merged commit 2a18502 into develop Jun 15, 2022
@flypaper0 flypaper0 deleted the approve-refactor-async branch June 15, 2022 12:49
@flypaper0 flypaper0 linked an issue Jun 16, 2022 that may be closed by this pull request
Refactor approval flow in engines #249
Closed
@flypaper0 flypaper0 mentioned this pull request Jun 16, 2022
Closed
@flypaper0 flypaper0 mentioned this pull request Jul 5, 2022
Merged
llbartekll pushed a commit that referenced this pull request Jul 5, 2022
@flypaper0 @llbartekll
ApproveEngine async calls (#270)
535f799 
* Approve and Reject Async

* Sync respond error removed

* Handle errors for respond calls

* Fix logger namings

* Fix integration tests

* UI tests performance fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@sekimondre sekimondre sekimondre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor approval flow in engines
3 participants
@flypaper0 @sekimondre @llbartekll