Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sign] Sessions publisher #634

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Dec 12, 2022

Description

Resolves #599

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

Docs PR: WalletConnect/walletconnect-docs#366

@arein arein added the accepted label Dec 12, 2022
@flypaper0 flypaper0 changed the base branch from main to develop December 12, 2022 11:20
@flypaper0 flypaper0 force-pushed the feature/sign-sessions-publisher-#599 branch from 6549ea9 to 4d85ea5 Compare December 12, 2022 11:21
@flypaper0 flypaper0 marked this pull request as ready for review December 12, 2022 11:39
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work my friend xd

@flypaper0 flypaper0 merged commit 8db3be7 into develop Dec 14, 2022
@flypaper0 flypaper0 deleted the feature/sign-sessions-publisher-#599 branch December 14, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Sign] onSessionUpdate Publisher
3 participants