Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Push, Echo] exposes all push client methods with implementations #635

Merged
merged 23 commits into from
Dec 19, 2022

Conversation

llbartekll
Copy link
Contributor

@llbartekll llbartekll commented Dec 14, 2022

Description

  • Implements all push sdk methods for wallet and dapp clients.
  • Integrates push in example wallet; automatic approval
  • extracts echo client
  • integrate cho client into example wallet

Resolves #603 #604 #605

How Has This Been Tested?

  • integration tests for push sdk
  • manual tests for push notifications
  • requires echo client UI/integration tests
  • requires to implement delete subscription integration test

Due Dilligence

  • Breaking change
  • Requires a documentation update

url: "example.wallet",
icons: ["https://avatars.githubusercontent.com/u/37784886"])

Networking.configure(projectId: InputConfig.projectId, socketFactory: DefaultSocketFactory())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, also faced with that a crash today

@@ -51,34 +76,26 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
let clientId = try! Networking.interactor.getClientId()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused clientId?

}

func register(deviceToken: Data) async throws {
let token = deviceToken.toHexString()
let tokenParts = deviceToken.map { data in String(format: "%02.2hhx", data) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is "%02.2hhx" ?

@llbartekll llbartekll merged commit a67da75 into develop Dec 19, 2022
@llbartekll llbartekll deleted the decryption-service branch December 19, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants