Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] Multi-account storage #687

Merged
merged 9 commits into from
Jan 30, 2023
Merged

[Chat] Multi-account storage #687

merged 9 commits into from
Jan 30, 2023

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Jan 25, 2023 •
edited
Loading

Description

  • KeyedDatabase implemented
  • AccountService
  • ChatStorage depends on KeyedDatabase's for Threads, Messages, Invites
  • register method change account in account service

Resolves https://github.com/WalletConnect/chat/issues/7

How Has This Been Tested?

Run Chat unit and integration tests

Due Dilligence

  • Breaking change
  • Requires a documentation update

@arein arein added the accepted label Jan 25, 2023
@flypaper0
Copy link
Contributor Author

Moving to draft. Need to resolve conversation in WalletConnect/walletconnect-docs#433 first

@flypaper0 flypaper0 marked this pull request as draft January 26, 2023 08:50
@flypaper0 flypaper0 marked this pull request as ready for review January 27, 2023 08:45
@flypaper0 flypaper0 merged commit 5dfb981 into develop Jan 30, 2023
@flypaper0 flypaper0 deleted the feature/chat-multiaccount branch January 30, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@alexander-lsvk alexander-lsvk Awaiting requested review from alexander-lsvk

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flypaper0 @llbartekll @arein