Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sign] CAIP-25 #688

Merged
merged 13 commits into from
Feb 15, 2023
Merged

[Sign] CAIP-25 #688

merged 13 commits into from
Feb 15, 2023

Conversation

alexander-lsvk
Copy link
Contributor

@alexander-lsvk alexander-lsvk commented Jan 25, 2023 •
edited
Loading

Due Dilligence

  • Breaking change
  • Requires a documentation update

@flypaper0
Copy link
Contributor

Do we also need to change namespaces validation code?
Will be nice to add some tests for optional namespaces in NamespaceValidationTests.swift

@alexander-lsvk
Copy link
Contributor Author

Do we also need to change namespaces validation code?
Will be nice to add some tests for optional namespaces in NamespaceValidationTests.swift

Yeah, I mentioned it in Slack, if implementation looks good to you, I'll push some tests 👌🏻

@alexander-lsvk alexander-lsvk changed the title Add optional namespaces [Sign] Add optional namespaces Jan 27, 2023
llbartekll
llbartekll reviewed Jan 30, 2023
View reviewed changes
Sources/WalletConnectSign/Namespace.swift Outdated
throw WalletConnectError.unsupportedNamespace(.unsupportedMethods)
}
if namespace.events.isEmpty {
throw WalletConnectError.unsupportedNamespace(.unsupportedEvents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it always required to have an event in optional namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-30 at 11 38 28

In the doc the whole namespace structure is covered regardless of being `required` or `optional` so I think so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the optional namespace contain the chains too then?
I don't think events and methods cannot be empty but let's discuss it today on the w3w meeting.

@flypaper0
Copy link
Contributor

will be good to add a few negative validation tests

llbartekll
llbartekll approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we merge it after js/swift/kotlin tests?
there may be some issues discovered

@alexander-lsvk alexander-lsvk changed the title [Sign] Add optional namespaces [Sign][WIP] CAIP-25 Feb 10, 2023
@alexander-lsvk alexander-lsvk changed the title [Sign][WIP] CAIP-25 [Sign] CAIP-25 Feb 15, 2023
@alexander-lsvk
Merge branch 'develop' into optional-namespaces
20b1ed8 
# Conflicts:
#	Example/WalletApp/PresentationLayer/Wallet/Wallet/WalletView.swift
@alexander-lsvk alexander-lsvk merged commit 755e1d6 into develop Feb 15, 2023
@alexander-lsvk alexander-lsvk deleted the optional-namespaces branch February 15, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@flypaper0 flypaper0 Awaiting requested review from flypaper0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-lsvk @flypaper0 @llbartekll