[Push, Wallet] Integrate push in wallet #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V2 into integrate-push-in-wallet # Conflicts: # Example/ExampleApp.xcodeproj/project.pbxproj # Sources/WalletConnectPush/Client/Dapp/ProposalResponseSubscriber.swift # Sources/WalletConnectPush/Client/Wallet/PushRequestResponder.swift
llbartekll
requested review from
alexander-lsvk and
flypaper0
and removed request for
alexander-lsvk
alexander-lsvk
approved these changes
Jan 27, 2023
flypaper0
reviewed
Jan 30, 2023
| self.contentHandler = contentHandler | ||
| bestAttemptContent = (request.content.mutableCopy() as? UNMutableNotificationContent) | ||
| if let bestAttemptContent = bestAttemptContent { | ||
| let topic = bestAttemptContent.userInfo["topic"] as! String |
There was a problem hiding this comment.
let's unwrap with "?" here?
flypaper0
reviewed
Jan 30, 2023
| @@ -31,6 +34,7 @@ final class SceneDelegate: UIResponder, UIWindowSceneDelegate { | |||
| app.uri = connectionOptions.urlContexts.first?.url.absoluteString.replacingOccurrences(of: "walletapp://wc?uri=", with: "") | |||
|
|
|||
| configurators.configure() | |||
| pushRegisterer.registerForPushNotifications() | |||
There was a problem hiding this comment.
We can put PushRegisterer into out service container and call:
app.pushRegisterer.registerForPushNotifications()
flypaper0
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
integrate Push sdk in the wallet app
Resolves #662
How Has This Been Tested?
manual testing of WalletApp with react dapp
Due Dilligence