[CI] Fastlane integration #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
force-pushed
the
feature/ci-fastlane
branch
from
3d3ba08
to
5bc7990
Compare
| build_wallet: | ||
| fastlane build scheme:WalletApp | ||
|
|
There was a problem hiding this comment.
Will it build apps with the every CI check?
If so I think it's a little bit overhead for the resources and time. This check would make more sense to me when merging to master i.e.
There was a problem hiding this comment.
Our tests is running in parallel, so CI time depends on longes test case. Now it is Integration tests. I can switch off this case if it make sense for you
flypaper0
force-pushed
the
feature/ci-fastlane
branch
from
464a836
to
0491087
Compare
| app_identifier: ENV["APP_IDENTIFIER"], | ||
| username: options[:username], | ||
| ) | ||
| increment_build_number( |
alexander-lsvk
approved these changes
Jan 30, 2023
|
@flypaper0 I think we should test it with Infra pipeline before merging. |
flypaper0
force-pushed
the
feature/ci-fastlane
branch
from
0491087
to
7e46da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For TestFlight release:
Install fastlane:
make install_envSetup environment
Match password I'll share. App specific password can be generated on apple.id website.
How Has This Been Tested?
Due Dilligence