[Core] Consume PublishedAt irn_subscription property #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectSwiftV2 into publishedAt
…V2 into publishedAt
…ectSwiftV2 into publishedAt
flypaper0
reviewed
Feb 21, 2023
| let topic: String | ||
| let message: String | ||
| let publishedAt: Date |
There was a problem hiding this comment.
do we need to rewrite encoder code?
we can parse it as is, make it private and create computed property:
private let publishedAt: UInt64
var timestamp: Date {
return Date(milliseconds: publishedAt)
}
flypaper0
reviewed
Feb 21, 2023
| @@ -19,6 +48,6 @@ struct Subscription: RelayRPC { | |||
| } | |||
|
|
|||
| init(id: String, topic: String, message: String) { | |||
| self.params = Params(id: id, data: Params.Contents(topic: topic, message: message)) | |||
| self.params = Params(id: id, data: Params.Contents(topic: topic, message: message, publishedAt: Date())) | |||
flypaper0
reviewed
Feb 21, 2023
| @@ -226,7 +226,7 @@ public final class RelayClient { | |||
| try rpcHistory.set(request, forTopic: params.data.topic, emmitedBy: .remote) | |||
| logger.debug("topic \(params.data.topic)") | |||
| logger.debug("message: \(params.data.message)") | |||
| messagePublisherSubject.send((params.data.topic, params.data.message)) | |||
| messagePublisherSubject.send((params.data.topic, params.data.message, params.data.publishedAt)) | |||
There was a problem hiding this comment.
may be rename to timestamp? See comment above
flypaper0
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consume
publishedAtirn_subscription property and pass it into RequestSubscriptionPayload that is published by networking interactorResolves # (issue)
How Has This Been Tested?
Due Dilligence