[Chat] Identity keys API #722
Conversation
| } | ||
|
|
||
| func registerIdentity(account: Account, | ||
| onSign: (String) -> CacaoSignature |
There was a problem hiding this comment.
as discussed we should request to sign async
There was a problem hiding this comment.
updated
created specs PR: WalletConnect/walletconnect-docs#510
| } | ||
|
|
||
| func registerInvite(account: Account, | ||
| onSign: (String) -> CacaoSignature |
There was a problem hiding this comment.
do we need onSign here?
| @@ -3,19 +3,29 @@ import Foundation | |||
| class KeyedDatabase<Element> where Element: Codable & Equatable { | |||
There was a problem hiding this comment.
do you think we could extract it from Chat to Utils?
There was a problem hiding this comment.
sounds good, I'll do it separately in InviteKeys package PR, ok?
| @@ -0,0 +1,54 @@ | |||
| import Foundation | |||
|
|
|||
| public struct ChatInviteKeyClaims: JWTEncodable { | |||
There was a problem hiding this comment.
as discussed - move to chat sdk
There was a problem hiding this comment.
also in InviteKeys package PR
|
|
||
| private extension Web3InboxViewController { | ||
|
|
||
| func onSing(_ message: String) -> SigningResult { |
There was a problem hiding this comment.
why we eventually need this?
There was a problem hiding this comment.
because we need to sign cacao from Chat SDK register method
| resources: [DIDKey] | ||
| ) | ||
|
|
||
| let result = await onSign(try messageFormatter.formatMessage(from: cacaoPayload)) |
There was a problem hiding this comment.
I understand, we're going to make it async later?
| ) | ||
| } | ||
|
|
||
| private func getNonce() -> String { |
There was a problem hiding this comment.
I feel a little like it gives 0 extra security when it's generated this way
There was a problem hiding this comment.
how we should do it?
| var sut: SocketAuthenticator! | ||
| let expectedToken = "eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJkaWQ6a2V5Ono2TWtvZEhad25lVlJTaHRhTGY4SktZa3hwREdwMXZHWm5wR21kQnBYOE0yZXh4SCIsInN1YiI6ImM0NzlmZTVkYzQ2NGU3NzFlNzhiMTkzZDIzOWE2NWI1OGQyNzhjYWQxYzM0YmZiMGI1NzE2ZTViYjUxNDkyOGUifQ.0JkxOM-FV21U7Hk-xycargj_qNRaYV2H5HYtE4GzAeVQYiKWj7YySY5AdSqtCgGzX4Gt98XWXn2kSr9rE1qvCA" | ||
|
|
||
| override func setUp() { | ||
| clientIdStorage = ClientIdStorageMock() | ||
| DIDKeyFactory = ED25519DIDKeyFactoryMock() | ||
| DIDKeyFactory.did = "did:key:z6MkodHZwneVRShtaLf8JKYkxpDGp1vGZnpGmdBpX8M2exxH" | ||
| // DIDKeyFactory = ED25519DIDKeyFactoryMock() |
There was a problem hiding this comment.
can we remove this commented code?
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence