[Chat] Identity package #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
reviewed
Feb 24, 2023
| private let networkingInteractor: NetworkInteracting | ||
| private let identityStorage: IdentityStorage | ||
| private let identityService: IdentityService | ||
| private let networkClient: NetworkInteracting |
There was a problem hiding this comment.
should we rename networkingInteractor to networkClient? we already got use to networkingInteractor and it's consistent in all the SDKs
I personally wouldn't do it
There was a problem hiding this comment.
reverted, planning to discuss it later
Comment on lines
-49
to
88
| private extension RegistryService { | ||
| private extension IdentityClient { | ||
|
|
||
| func subscribeForInvites(inviteKey: AgreementPublicKey) async throws { | ||
| let topic = inviteKey.rawRepresentation.sha256().toHexString() | ||
| try kms.setPublicKey(publicKey: inviteKey, for: topic) | ||
| try await networkingInteractor.subscribe(topic: topic) | ||
| try await networkClient.subscribe(topic: topic) | ||
| } | ||
|
|
||
| func unsubscribeFromInvites(inviteKey: AgreementPublicKey) { | ||
| let topic = inviteKey.rawRepresentation.sha256().toHexString() | ||
| kms.deletePublicKey(for: topic) | ||
| networkingInteractor.unsubscribe(topic: topic) | ||
| networkClient.unsubscribe(topic: topic) | ||
| } | ||
| } |
There was a problem hiding this comment.
could this be a part of the Chat sdk?
Identity Package for client->server interaction
but this part is just chat peer to peer
2 tasks
|
@llbartekll suggestions fixed in #735 |
llbartekll
reviewed
Feb 27, 2023
|
Merged with #735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence