[Core] CAIP-10 regex fixed #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
approved these changes
Mar 28, 2023
|
@nerzh your PR's branch has a strange state (25 merge commits). Also need to fix unit tests |
|
@flypaper0 ok, let me download the project again and re-upload with test fixes ? |
|
although I changed my mind 🙄, do as you wish, have a nice day, bye |
|
Ok, I'll merge this. Normally we are doing branch from fresh develop, doing commits, and PR in develop. I think the reason of bad branch in your PR, that you initially created branch from main, and after changed destination branch to develop. Thanks for contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CAIP-10 Regex updated with https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-10.md#syntax
Resolves #761
How Has This Been Tested?
Due Dilligence