Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] Sync API #858

Merged
merged 35 commits into from
Jun 6, 2023
Merged

[Chat] Sync API #858

merged 35 commits into from
Jun 6, 2023

Conversation

flypaper0
Copy link
Contributor

Description

  • Sync API client + integration tests
  • SyncStore and store delegates for Chat
  • Chat SyncAPI integrations

SyncStores:

  • SentInvite including (inviterPubKeyY, inviterPrivKeyY, responseTopic, symKey)
  • InviteKey including (pubKey, privKey)
  • Thread including (symKey)
  • Breaking change
  • Requires a documentation update

@flypaper0 flypaper0 force-pushed the feature/sync-api branch 2 times, most recently from 4a9e4db to d7fd719 Compare May 26, 2023 12:53
@flypaper0 flypaper0 marked this pull request as ready for review May 26, 2023 15:02
@flypaper0 flypaper0 temporarily deployed to internal May 29, 2023 13:08 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal May 29, 2023 13:09 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal May 30, 2023 13:33 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal June 1, 2023 12:09 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal June 1, 2023 12:22 — with GitHub Actions Inactive
llbartekll
llbartekll reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work,
I would just consider the interface segregation in crypto provider

Example/IntegrationTests/Auth/ENS/ENSResolverTests.swift Show resolved Hide resolved
Example/IntegrationTests/Sync/SyncTests.swift Show resolved Hide resolved
Example/Shared/DefaultCryptoProvider.swift Show resolved Hide resolved
Sources/WalletConnectSigner/CryptoProvider.swift Outdated Show resolved Hide resolved
Sources/WalletConnectSync/Stores/SyncObjectStore.swift Show resolved Hide resolved
Sources/WalletConnectSync/Stores/SyncStore.swift Show resolved Hide resolved
@flypaper0 flypaper0 temporarily deployed to internal June 5, 2023 15:18 — with GitHub Actions Inactive
@flypaper0 flypaper0 requested a review from llbartekll June 5, 2023 16:11
@flypaper0 flypaper0 temporarily deployed to internal June 6, 2023 10:56 — with GitHub Actions Inactive
llbartekll
llbartekll approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better to me right now!

@flypaper0 flypaper0 temporarily deployed to internal June 6, 2023 11:45 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal June 6, 2023 12:14 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal June 6, 2023 12:49 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal June 6, 2023 13:31 — with GitHub Actions Inactive
@flypaper0 flypaper0 merged commit fb219e6 into develop Jun 6, 2023
@flypaper0 flypaper0 deleted the feature/sync-api branch June 6, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@radeknovis radeknovis Awaiting requested review from radeknovis

@alexander-lsvk alexander-lsvk Awaiting requested review from alexander-lsvk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flypaper0 @llbartekll