[CI&CD] Fix CI runs for PRs from forks #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
allow-external-PRs
branch
from
db60d48
to
650a768
Compare
radeknovis
force-pushed
the
allow-external-PRs
branch
from
650a768
to
9b0c317
Compare
radeknovis
commented
May 26, 2023
| name: ci_v2 | ||
|
|
||
| on: | ||
| pull_request_target: |
There was a problem hiding this comment.
Runs triggered using this event have access to secrets.
radeknovis
commented
May 26, 2023
| environment: | ||
| ${{ (github.event_name == 'pull_request_target' && | ||
| github.event.pull_request.head.repo.full_name != github.repository) && | ||
| 'external' || 'internal' }} |
There was a problem hiding this comment.
This external vs internal environment would differentiate between regular PRs and PRs incoming from forks and we can require approval and we can specify that external ones need approval before running.
radeknovis
changed the title
llbartekll
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context here: https://iterative.ai/blog/testing-external-contributions-using-github-actions-secrets
NB: This is complicated to test as it needs to be merged in
mainfirst, so it is split in two parts leaving originalciworkflow unchanged