[W3M] SDK Interface cleanup #898
Conversation
radeknovis
force-pushed
the
feature/cleanup-api
branch
from
7fe5d7c
to
374161c
Compare
radeknovis
force-pushed
the
feature/cleanup-api
branch
from
58ddec6
to
0eed6c7
Compare
radeknovis
force-pushed
the
feature/cleanup-api
branch
from
37a113b
to
f173667
Compare
radeknovis
force-pushed
the
feature/cleanup-api
branch
from
f173667
to
084f586
Compare
|
|
||
| /// For proposing a session to a wallet. | ||
| /// Function will propose a session on newly created pairing. | ||
| public func createPairingAndConnect() async throws -> WalletConnectURI { |
There was a problem hiding this comment.
would make sense to call the method just connect() with an optional topic?
same as deprecated method of sign client
public func connect(
requiredNamespaces: [String: ProposalNamespace],
optionalNamespaces: [String: ProposalNamespace]? = nil,
sessionProperties: [String: String]? = nil,
topic: String? = nil
There was a problem hiding this comment.
actually would match kotlin's interface too
| public static func set(sessionParams: SessionParams) { | ||
| Web3Modal.config.sessionParams = sessionParams | ||
| } |
There was a problem hiding this comment.
what the set method is for?
what's the difference between configure()?
There was a problem hiding this comment.
I thought this could be used to change sessionParams on fly (e.g. users selects different chain) while configure() is more like a one time initialisation
There was a problem hiding this comment.
I see, does it work? It’s singletons and config is used on the instantiation, so with the first call only
There was a problem hiding this comment.
Yes, it works. Config is stored as a static variable, which can be changed only via these 2 methods. I'm calling set() from Dapp
No description provided.