Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WCM] macOS & iPad support #931

Merged
merged 4 commits into from
Jul 5, 2023
Merged

[WCM] macOS & iPad support #931

merged 4 commits into from
Jul 5, 2023

Conversation

radeknovis
Copy link
Contributor

@radeknovis radeknovis commented Jun 28, 2023 •
edited
Loading

Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 24
Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 27
Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 30
Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 32
Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 34
Simulator Screenshot - iPad (10th generation) - 2023-07-04 at 17 07 38

@radeknovis radeknovis temporarily deployed to internal June 28, 2023 09:58 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal June 28, 2023 10:20 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal June 28, 2023 10:48 — with GitHub Actions Inactive
@llbartekll llbartekll self-requested a review June 30, 2023 10:10
flypaper0
flypaper0 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@flypaper0 flypaper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks nice, @radeknovis could you please attach a few screenshots please?

@radeknovis radeknovis temporarily deployed to internal July 4, 2023 14:44 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal July 4, 2023 15:08 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal July 4, 2023 15:43 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal July 4, 2023 16:41 — with GitHub Actions Inactive
@radeknovis radeknovis temporarily deployed to internal July 5, 2023 09:31 — with GitHub Actions Inactive
@radeknovis radeknovis merged commit 6a23e33 into develop Jul 5, 2023
@radeknovis radeknovis deleted the fix/wcm-macos-support branch July 5, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@alexander-lsvk alexander-lsvk alexander-lsvk approved these changes

@flypaper0 flypaper0 flypaper0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeknovis @flypaper0 @alexander-lsvk @llbartekll