[WalletApp] Import account and settings screen #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
reviewed
Jul 5, 2023
| Button("OK", role: .cancel) { } | ||
| } | ||
| .onAppear { | ||
| viewModel.objectWillChange.send() |
There was a problem hiding this comment.
To get actual data on every on appear
radeknovis
reviewed
Jul 5, 2023
Example/WalletApp/PresentationLayer/Wallet/Settings/SettingsView.swift
Outdated
Show resolved
Hide resolved
radeknovis
reviewed
Jul 5, 2023
|
|
||
| let title: String | ||
| let placeholder: String | ||
| let input: Binding<String> |
There was a problem hiding this comment.
nit: you don't fancy @binding property wrapper? :P
radeknovis
approved these changes
Jul 5, 2023
alexander-lsvk
approved these changes
Jul 6, 2023
llbartekll
approved these changes
Jul 6, 2023
flypaper0
force-pushed
the
feature/wallet-app-import
branch
from
1fd28f9
to
51af657
Compare
llbartekll
reviewed
Jul 7, 2023
| self.client = client | ||
| self.onSign = onSign | ||
|
|
||
| Task { |
There was a problem hiding this comment.
won't be any issues with .priority ?
llbartekll
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence