Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verify] Remove opt-in/out flag for VerifyAPI #946

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

alexander-lsvk
Copy link
Contributor

@alexander-lsvk alexander-lsvk commented Jul 6, 2023

Remove the option to opt-in/out for VerifyAPI in the code, since this option migrated to the cloud.
Screenshot 2023-07-06 at 11 22 36

Due Dilligence

  • Breaking change
  • Requires a documentation update

@alexander-lsvk alexander-lsvk temporarily deployed to internal July 6, 2023 09:22 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 6, 2023 09:40 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 6, 2023 11:06 — with GitHub Actions Inactive
@@ -44,3 +49,19 @@ public actor VerifyClient {
try await assertionRegistrer.registerAssertion()
}
}

#if DEBUG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radeknovis 🫡😁

@alexander-lsvk alexander-lsvk temporarily deployed to internal July 10, 2023 17:35 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 10, 2023 19:23 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk temporarily deployed to internal July 10, 2023 19:39 — with GitHub Actions Inactive
@alexander-lsvk alexander-lsvk merged commit 9afc7e3 into develop Jul 10, 2023
@alexander-lsvk alexander-lsvk deleted the verify-api-remove-opt-in-out branch July 10, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants