[VDG] UI Decoupling #33 #11057
Merged
[VDG] UI Decoupling #33 #11057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
RolandUI
approved these changes
Aug 15, 2023
| @@ -280,7 +280,9 @@ private void RegisterViewModels() | |||
| { | |||
| if (!string.IsNullOrEmpty(walletViewModel.Wallet.Kitchen.SaltSoup())) | |||
| { | |||
| var pwAuthDialog = new PasswordAuthDialogViewModel(walletViewModel.Wallet); | |||
| // TODO: Remove reference to WalletRepository when this ViewModel is Decoupled | |||
| // TODO: Why is this code duplicated? | |||
There was a problem hiding this comment.
@ichthus1604
In general, every item in the SearchBar that requires a wallet to be logged in, just doesn't make sense.
Should be removed.
There was a problem hiding this comment.
Like, wallet info, send, receive etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHardwareWalletModel, which inheritsIWalletModeland contains additional HW-specific APIs.HardwareWalletAuthDialogViewModelPasswordAuthDialogViewModel