Cancellation TX to reset input AS #11236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While testing this I got a cancellation tx that was confirmed but it had no icon and no labels. I am not sure it is related to this PR: |
|
Do you want this in the release? https://github.com/zkSNACKs/WalletWasabi/commits/v2.0.4 |
|
I'm the Buddha. I have no wants. But sure, add it. |
Nice trick, but I see through you Buddha attack type. I am Buddha as well and wait until you create the PR or let it go. AUMMMM |
|
At last, your third eye bested mine. Then let's practice mindfulness and let it go. AUMMM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the blockchain analyzer encounters a cancellation transaction with foreign inputs - a technical impossibility but a logical possibility - or foreign outputs, then set its input anonsets to 0.
It may not comprehensively fix all the problems noted in #11226. However, it improves and closes #11226
After this PR, a new issue may be opened if there are still any problems.