Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the remaining InsecureRandom usages #12894

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

csiki2
Copy link
Contributor

@csiki2 csiki2 commented Apr 18, 2024

Removing the remaining InsecureRandom usage.

Fixes #10857

Removing the remaining InsecureRandom usage.
Using secureRandom for credential generation.
@csiki2 csiki2 self-assigned this Apr 18, 2024
@csiki2 csiki2 requested a review from molnard April 18, 2024 10:58
@csiki2 csiki2 changed the title Removing the remaining InsecureRandom usage Removing the remaining InsecureRandom usages Apr 18, 2024
@kiminuo kiminuo requested review from lontivero and removed request for kiminuo April 18, 2024 15:26
@csiki2
Copy link
Contributor Author

csiki2 commented Apr 22, 2024

Hi @onvej-sl,
could you please look at this change?

@onvej-sl
Copy link
Contributor

Hi @onvej-sl,
could you please look at this change?

It looks good.

@csiki2
Copy link
Contributor Author

csiki2 commented Apr 23, 2024

Thank you!

Copy link
Contributor

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 8896555 into WalletWasabi:master Apr 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inappropriate use of random number generator
3 participants