Skip to content

Commit

Permalink
Turn off SFS archival, add SFS fh computation
Browse files Browse the repository at this point in the history
Adds SFS to the list of supported runs for `Tasks._get_forecast_hours()`

Turns off the archive job for SFS for the time being until an appropriate
yaml is created.
  • Loading branch information
WalterKolczynski-NOAA committed Jan 30, 2025
1 parent 2bbef76 commit 0d586c4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions parm/config/sfs/config.base
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export DO_OCN="NO"
export DO_ICE="NO"
export DO_EXTRACTVARS="@DO_EXTRACTVARS@" # Option to process and extract a subset of products to save on disk
export DO_AERO_FCST="NO"
export DOBNDPNT_WAVE="NO" # The GEFS buoys file does not currently have any boundary points
export DOBNDPNT_WAVE="NO" # The SFS buoys file does not currently have any boundary points
export DOIBP_WAV="NO" # Option to create point outputs from input boundary points
export FRAC_GRID=".true."
export DO_NEST="NO" # Whether to run a global-nested domain
Expand All @@ -152,7 +152,7 @@ export OPS_RES="C768" # Do not change

# Resolution specific parameters
export LEVS=128
export CASE="@CASECTL@" # CASE is required in GEFS to determine ocean/ice/wave resolutions
export CASE="@CASECTL@" # CASE is required in SFS to determine ocean/ice/wave resolutions
export CASE_ENS="@CASEENS@"
export OCNRES="@OCNRES@"
export ICERES="${OCNRES}"
Expand Down
3 changes: 2 additions & 1 deletion workflow/applications/sfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ def get_task_names(self):
tasks += ['wavepostpnt']

if options['do_extractvars']:
tasks += ['extractvars', 'arch']
tasks += ['extractvars']

# TODO: Add archive
tasks += ['cleanup']

return {f"{self.run}": tasks}
6 changes: 3 additions & 3 deletions workflow/rocoto/sfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def _atmosoceaniceprod(self, component: str):
max_tasks = self._configs[config]['MAX_TASKS']
resources = self.get_resource(config)

fhrs = self._get_forecast_hours('gefs', self._configs[config], component)
fhrs = self._get_forecast_hours('sfs', self._configs[config], component)

# when replaying, atmos component does not have fhr 0, therefore remove 0 from fhrs
is_replay = self._configs[config]['REPLAY_ICS']
Expand Down Expand Up @@ -276,7 +276,7 @@ def atmos_ensstat(self):

dependencies = rocoto.create_dependency(dep_condition='and', dep=deps)

fhrs = self._get_forecast_hours('gefs', self._configs['atmos_ensstat'])
fhrs = self._get_forecast_hours('sfs', self._configs['atmos_ensstat'])

# when replaying, atmos component does not have fhr 0, therefore remove 0 from fhrs
is_replay = self._configs['atmos_ensstat']['REPLAY_ICS']
Expand Down Expand Up @@ -327,7 +327,7 @@ def wavepostsbs(self):
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep=deps, dep_condition='or')

fhrs = self._get_forecast_hours('gefs', self._configs['wavepostsbs'], 'wave')
fhrs = self._get_forecast_hours('sfs', self._configs['wavepostsbs'], 'wave')

# When using replay, output does not start until hour 3
is_replay = self._configs['wavepostsbs']['REPLAY_ICS']
Expand Down
2 changes: 1 addition & 1 deletion workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def _get_forecast_hours(run, config, component='atmos') -> List[str]:
fhmax = local_config['FHMAX']
fhout = local_config['FHOUT']
fhrs = list(range(fhmin, fhmax + fhout, fhout))
elif run in ['gfs', 'gefs']:
elif run in ['gfs', 'gefs', 'sfs']:
fhmax = local_config['FHMAX_GFS']
fhout = local_config['FHOUT_GFS']
fhout_hf = local_config['FHOUT_HF_GFS']
Expand Down

0 comments on commit 0d586c4

Please sign in to comment.