Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board stream incoming events API - emit gameFinish event for aborted games #857

Closed
ddugovic opened this issue Sep 2, 2024 · 2 comments
Closed

Comments

@ddugovic
Copy link

ddugovic commented Sep 2, 2024

I made a Twitch bot which creates and resolves predictions ("Who will win?") when games start and finish, based upon Lichess' Board API: https://github.com/ddugovic/Twitch-Prediction-Lichess/tree/lishogi

However, when porting this bot to use the Lishogi API, if a game is aborted the board API fails to emit a gameFinish event:
https://lishogi.org/api#tag/Board/operation/apiStreamEvent

ddugovic added a commit to ddugovic/lishogi that referenced this issue Sep 15, 2024
WandererXII pushed a commit that referenced this issue Sep 17, 2024
* API - publish gameFinish event for #857

* add game source to gameStart bot/board event

* send more game preview data in event stream gameStart & gameFinish

* add `status` and `winner` fields to the event stream game objects

* Fix AI name typo

---------

Co-authored-by: Thibault Duplessis <t@lichess.org>
@WandererXII
Copy link
Owner

Solved with 931487f?

@ddugovic
Copy link
Author

Yes, thank you very much for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants