Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define first player for #708 and for #738 #866

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

ddugovic
Copy link

First player has at least two meanings:

  • Which player has the greater reputation? (ou / gyoku)
  • From which perspective do we wish to view a game?

This PR does not modify art assets, but does change the "Player before" definition to consider:

  • Humans have a greater reputation than engines
  • Titled players have a greater reputation than non-titled players

Although Lichess TV prefers to display games from the perspective of the higher-rated player, for Lishogi TV we should prefer to view a game from:

  • Handicap games: handicap receiver perspective
  • Human perspective (or if BOT versus AI, BOT perspective)
  • Higher-rated player perspective

@WandererXII WandererXII merged commit ff04ccc into WandererXII:master Sep 28, 2024
2 checks passed
@WandererXII
Copy link
Owner

LGTM, thanks! Maybe we should rename firstColor and firstPlayer to something else, so it doesn't sound like first player to move.

@ddugovic
Copy link
Author

ddugovic commented Sep 28, 2024

Indeed... maybe something like tvColor and tvFirstPlayer since existing names (e.g. "orientation", "pov") don't seem to be a good fit either.

But also sentePlayer before gotePlayer identifies the player with greater reptuation, which someday could be useful for assigning the king general versus jewel general pieces.

@ddugovic ddugovic deleted the game-tv-color branch October 26, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants