Save numbers to vars as is #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroy666x
force-pushed
the
SaveNumbersToVarsAsIs
branch
from
6235067 to
94a9c62
Compare
WarmUpTill
reviewed
Feb 22, 2024
Destroy666x
force-pushed
the
SaveNumbersToVarsAsIs
branch
4 times, most recently
from
02dea85 to
1be43f1
Compare
WarmUpTill
force-pushed
the
SaveNumbersToVarsAsIs
branch
3 times, most recently
from
191ca60 to
b3c5935
Compare
WarmUpTill
force-pushed
the
SaveNumbersToVarsAsIs
branch
2 times, most recently
from
6052bd2 to
1669341
Compare
WarmUpTill
force-pushed
the
SaveNumbersToVarsAsIs
branch
from
1669341 to
286e463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
to_stringusedsprintfunder the hood and added a random number of zeros after., depending on compiler. This should be much more consistent. Even better would bestd::formatfrom what I read, but it's only C++20 and that was impossible for now.GetDouble/GetIntfunctions to avoid some false conversions. Only upper limit of double was checked for some reason earlier. This is still far from perfect as you can't go up to max, but shouldn't matter too much. Also, bigger numbers support would be nice with different types, but I'll create another issue for that.