Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max length validation support for TextEdit #894

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Oct 4, 2023

image

Adds maxLength support to TextEdit, then also consitently displays message for LineEdit. Should be ready to merge from my side

@WarmUpTill
Copy link
Owner

Thanks, looks good! :)
I will try to test and merge it tomorrow.

@Destroy666x
Copy link
Contributor Author

BTW. is modal bool of DisplayMessage supposed to do something different? I tested with true/false and noticed 0 difference for non-question messages at least.

@WarmUpTill
Copy link
Owner

BTW. is modal bool of DisplayMessage supposed to do something different? I tested with true/false and noticed 0 difference for non-question messages at least.

Visually they are the same.
They only differ in how they behave in regards to the interaction with other windows of the same application.

To be concrete, modal dialogs will prevent you from interacting with other windows of the application, until they are closed, while non-modal dialogs do not.

For example, the advanced scene switcher plugin's settings window is a non-modal dialog window as it still allows you to interact with OBS while the dialog window is open.

Hope that clears things up! :)

@WarmUpTill WarmUpTill merged commit e13e4b5 into WarmUpTill:master Oct 5, 2023
10 checks passed
@Destroy666x
Copy link
Contributor Author

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants