Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add widget popup actions #899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Destroy666x
Copy link
Contributor

@Destroy666x Destroy666x commented Oct 20, 2023

Also makes DisplayMessage's text selectable.

WIP because it unfortunately doesn't work outside of the Advanced Scene Switcher settings window - it hangs OBS. I learned later that global popups may be (still) impossible to achieve.

So not too sure what to do with it - maybe you'll have a better idea @WarmUpTill. For now submitting as PR to free stash. If not then I guess this could be redone when the'll make this possible.

@WarmUpTill
Copy link
Owner

Thanks!
I will try to have a look during the weekend.

WIP because it unfortunately doesn't work outside of the Advanced Scene Switcher settings window - it hangs OBS

Did you maybe have a dialog in mind like it is used in the variable action with the "ask for input option"?

grafik
If so this code snippet might help.

@Destroy666x
Copy link
Contributor Author

Thanks, more or less, so you're saying the non-modal class is made to work anywhere in OBS? If so, I'll take a look later today.

@WarmUpTill
Copy link
Owner

I think what might be causing the crashes is that you are trying to open a modal dialog from a non-UI thread.
You might have to use obs_queue_task() to do that.

The non-modal dialog might not run into this issue, but to be honest I am mostly guessing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants