Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp var #901

Merged
merged 22 commits into from
Nov 20, 2023
Merged

Temp var #901

merged 22 commits into from
Nov 20, 2023

Conversation

WarmUpTill
Copy link
Owner

No description provided.

@WarmUpTill WarmUpTill linked an issue Oct 22, 2023 that may be closed by this pull request
[feature request] Variable JSON processing - e.g. value extraction #900
Closed
@WarmUpTill WarmUpTill force-pushed the temp-var branch 5 times, most recently from 654e280 to 2133f2a Compare November 6, 2023 18:41
@WarmUpTill WarmUpTill force-pushed the temp-var branch 6 times, most recently from 2e731db to 61d2300 Compare November 15, 2023 14:43
@Destroy666x
Copy link
Contributor

Destroy666x commented Nov 15, 2023 •
edited
Loading

I tested the condition and seems to work perfectly, time to play around with that a bit.

The only bigger thing that I'd change, except small ones mentioned as code comments, would be the list and items it contains, which I also mentioned earlier on Discord.

E.g. in this case:
image

I definitely don't think this should show the User banned from channel macro vars and stop listing at the "segment" position at which the list is. Especially now that clearing variables looks to be solved and the further macro vars will always be empty in that context.

@WarmUpTill
Copy link
Owner Author

I tested the condition and seems to work perfectly, time to play around with that a bit.

The only bigger thing that I'd change, except small ones mentioned as code comments, would be the list and items it contains, which I also mentioned earlier on Discord.

E.g. in this case: image

I definitely don't think this should show the User banned from channel macro vars and stop listing at the "segment" position at which the list is. Especially now that clearing variables looks to be solved and the further macro vars will always be empty in that context.

I updated the PR to include that functionality.
Should work but couldn't really test it yet.

@Destroy666x
Copy link
Contributor

Destroy666x commented Nov 16, 2023 •
edited
Loading

Nice. After quick test, it works well in the case mentioned above, but then action one is empty:
image

Same thing applies to else block. So it forgets to fill all condition ones for these.

@WarmUpTill
Copy link
Owner Author

Right - forgot about that.
I updated the PR once again.

@WarmUpTill WarmUpTill force-pushed the temp-var branch 7 times, most recently from 269ed0b to 6b9aba2 Compare November 19, 2023 14:32
@WarmUpTill
Fix crash while running macro actions
326ebfb 
Users could invalidate the actions vector while the actions were
executed resulting in a crash.
@WarmUpTill
Add AddPostLoadStep()
3e84af2 
Enables registering additional functions, which are to be executed after
the loading steps are complete
@WarmUpTill
Run PostLoad() for "else actions" as well
d075bc5
@WarmUpTill
Add nlohmann json dependency
d646c86
@WarmUpTill
Add action to enable extraction of values from json string
836fb7c
@WarmUpTill
Enable extraction of array values from channel info
6183393
@WarmUpTill
Add temporary variables
b68c7d7 
Enables easier use of values returned by macro segments.
For example, this enables the user to extract the user name of a new
Twitch follower and change a text sources settings accordingly
@WarmUpTill
Add support for setting variable to value of temporary variable
b9034b0
@WarmUpTill
Fix content content_classification_labels not being set
3487ca1
@WarmUpTill
Set temporary variables in Twitch condition
c0b8817
@WarmUpTill
Add SourceSetting helpers
295a96d 
They enable easy modification of single setting value of sources
compared to working with the raw json string
@WarmUpTill
Use SourceSetting helpers to enable modification of single setting
b679388
@WarmUpTill
Add temp variable support for audio condition
d20441b
@WarmUpTill
Add temp variable support to window condition
4d70d4f
@WarmUpTill
Add temp variable support to scene condition
7c1802e
@WarmUpTill
Clean up locale and variable condition
ef2da38
@WarmUpTill
Add condition to check temporary variable values / macro properties
11e498c
@WarmUpTill
Enable use of variables in find and replace options of variable action
b55cd3c
@WarmUpTill
Add temp variable support to timer condition
30208fe
@WarmUpTill
Add temp variable support to date condition
21ae1ec
@WarmUpTill WarmUpTill merged commit 50dc404 into master Nov 20, 2023
10 checks passed
@WarmUpTill WarmUpTill deleted the temp-var branch November 20, 2023 19:08
@filiphanes
Copy link

JSON Pointer may be simpler and still powerful syntax
https://www.rfc-editor.org/rfc/rfc6901

@Destroy666x
Copy link
Contributor

Do you mean simplier in terms of implementation? Or for users? If the 2nd then both are fairly easy IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Destroy666x Destroy666x Destroy666x left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Variable JSON processing - e.g. value extraction
3 participants
@WarmUpTill @Destroy666x @filiphanes