Cleanup #952
Merged
Cleanup #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarmUpTill
force-pushed
the
cleanup
branch
7 times, most recently
from
3459c15 to
5988ba8
Compare
WarmUpTill
force-pushed
the
cleanup
branch
7 times, most recently
from
147cb46 to
db3345c
Compare
Added to reduce dependencies to switcher-data
In some scenarios - the exact reason is not known - the widget would scroll to the very last row, which is always empty, and result in the text cursor and the already entered text being moved above the displayed edit area. It could be fixed by manually scrolling back up (e.g. by attempting to highlight text with the mouse), but the problem would reappear as soon as new existing text was modified. To work around this issue text wrapping was disabled and additional height will be added for the horizontal scroll bar, if they are visible. There are still some issues of the height randomly flickering in the scenarios, which would previously result in the text no longer being visible.
Now a horizontal scroll bar will be displayed in the corresponding MacroSegmentList widget instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.