Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable RDS IAM DB auth #418

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

ZoogieZork
Copy link
Contributor

Description

Adds an option to enable IAM authentication to the RDS cluster.

Enabling this option does not affect how Artemis connects to the database, it just enables an alternate method for admins to connect to the database.

Motivation and Context

This option may be required by organization security policy.

How Has This Been Tested?

Deployed to non-prod environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ZoogieZork ZoogieZork marked this pull request as ready for review February 5, 2025 22:51
@ZoogieZork ZoogieZork requested a review from a team as a code owner February 5, 2025 22:51
Copy link
Contributor

@g-marconet g-marconet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems pretty straightforward

@ZoogieZork ZoogieZork merged commit 402b05f into main Feb 5, 2025
6 checks passed
@ZoogieZork ZoogieZork deleted the zoogiezork/db-iam-auth branch February 5, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants