Handle all API endpoints through the authorizer #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determining whether a path skips authorization is moved to the authorizer lambda. This allows for additional handling of "passthrough" requests by modifying the authorizer, such as logging or additional contextual routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves all API Gateway endpoints to use the authorizer, including the ones previously using the
NONEauthorizer.Additionally, the bulk of the type-checking issues have been corrected, but some remain (due to limitations with typechecking Django models).
Motivation and Context
Keeps all of the authorization logic in a single place. This enables future flexibility in handling these requests, such as additional logging.
Additionally, this works around security scanners which flag any API Gateway resource with a
NONEauthorizer.How Has This Been Tested?
Tested in non-prod environment.
Types of changes
Checklist