Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old log files #2501

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

past-due
Copy link
Member

Only keep a certain number of > 7 day-old log files.

@past-due past-due added this to the 4.2.4 milestone Dec 13, 2021
@past-due past-due requested a review from KJeff01 December 13, 2021 00:22
Copy link
Member

@KJeff01 KJeff01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright.

Should we also remove any dump files (or any other file) older than, say, 30 days in that folder?

@past-due
Copy link
Member Author

Should we also remove any dump files (or any other file) older than, say, 30 days in that folder?

Probably a good thing to look into for a future release. There may be some exceptions to that (such as: we may not want to remove an old .RPT file).

I'll merge this PR to clean up the most common (and aggressively-accumulating) log files. And we can tackle the rest separately. 👍

@past-due past-due merged commit d5ed1a5 into Warzone2100:master Dec 15, 2021
@past-due past-due deleted the 2021_12_cleanup_old_logs_1 branch December 15, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants