Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Link fmt library #118

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[Fix] Link fmt library #118

merged 1 commit into from
Jul 29, 2024

Conversation

CaptainVincent
Copy link
Member

Fix undefined reference to fmtt::v10::*** when we static build with wasmedge.

Signed-off-by: vincent <vincent@secondstate.io>
@L-jasmine
Copy link
Collaborator

LGTM

@L-jasmine L-jasmine merged commit ef01eb6 into WasmEdge:main Jul 29, 2024
37 checks passed
@jprendes
Copy link
Contributor

Has this been tested? What distribution and what package provides static builds of libfmt?
AFAIK, alpine doesn't provide static build of libfmt, and libfmt v10 is only experimental in debian.

@L-jasmine
Copy link
Collaborator

@CaptainVincent wasmedge 0.14 need libfmt?

@L-jasmine
Copy link
Collaborator

Has this been tested? What distribution and what package provides static builds of libfmt? AFAIK, alpine doesn't provide static build of libfmt, and libfmt v10 is only experimental in debian.

In our CI, there are no tests for Alpine. I have just merged this PR into the main branch, but it has not been released yet. Is Alpine important to you? If so, please open an issue to discuss continuous support for Alpine.

@L-jasmine
Copy link
Collaborator

It also only affects static linking.

@jprendes
Copy link
Contributor

The particular distro is not very important, but we do use the alpine packages for static linking. In general a test for static linking (regardless of the distribution) and for the standalone feature would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: link to static lib 0.14.0 encounters undefined reference to fmtt::v10::***
3 participants