Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thread is started in SoftU2FDaemon/Program.cs:
This code in U2FLib/U2FHIDDeviceCommunication.cs blocks the Thread execution:
In SoftU2FDaemon/Program.cs this call initiates the cancellation of Thread:
However, in C# there are no forced Thread cancellations, the cancellations only work as a signal, and if the Thread is blocked by DeviceIoControl, it won't have its event loop run, therefore it doesn't forcefully end.
I have added Register callback to after the Thread cancellation was signaled, and if an exit was requested too, then we shut down the process.
This fixes #72