Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: transfer views to same workspace as on destroyed output #2294

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

core: transfer views to same workspace as on destroyed output #2294

wants to merge 4 commits into from

Commits on Apr 12, 2024

  1. core: add move_view_to_output overload that takes flags

    @lcolitti
    lcolitti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8559fb7 View commit details
    Browse the repository at this point in the history

  2. core: transfer views to same workspace as on destroyed output 

    Currently, when an output is destroyed, views are transferred to
the new output in roughly the same position as they were on the
old output, but they are all transferred to the first workspace.

This is annoying: if they were not on the first workspace, then
the user must have moved them, and after they're transferred, the
user must will have to move them agein.

Instead, in the (common?) case that the old and the new output
have the same number of workspaces, move each view to the same
workspace it was on before.
    @lcolitti
    lcolitti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b99cb04 View commit details
    Browse the repository at this point in the history

  3. output-layout: make NOOP-1 output larger. 

    When outputs are unplugged, views are temporarily moved to the
NOOP-1 output. Because this output is currently only 1280x720,
windoes moved to it get moved and cropped to match its small
screen size.

Make the output 4k so windows stay where they are unless the user
is running a display larger than 4k.

This does not affect the WL-x outputs used when running in
headless mode, which continue to be created as 1280x720 by
wlroots code (attempt_headless_backend).
    @lcolitti
    lcolitti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    74c2181 View commit details
    Browse the repository at this point in the history

  4. output-layout: keep active workspace when destroying output 

    Currently, when destroying the current output, core focuses the
next output (if any) but does not switch to the same workspace
that the user was previously using. Switch to the same workspace
so the user can pick up where they left off.
    @lcolitti
    lcolitti committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c97972f View commit details
    Browse the repository at this point in the history