Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

animate: Add zap animation #2411

Merged
merged 7 commits into from
Aug 27, 2024
Merged

animate: Add zap animation #2411

merged 7 commits into from
Aug 27, 2024

Conversation

soreau
Copy link
Member

@soreau soreau commented Jul 28, 2024

No description provided.

@soreau soreau changed the title Add zap animation animate: Add zap animation Aug 3, 2024
ammen99
ammen99 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but cool animation! Tested and it works perfectly, also lgtm, so we can merge when you rebase.

@soreau
Copy link
Member Author

soreau commented Aug 27, 2024

Simple but cool animation! Tested and it works perfectly, also lgtm, so we can merge when you rebase.

Great! It's been rebased, and added a dedicated duration option.

@soreau soreau requested a review from ammen99 August 27, 2024 16:50
@ammen99 ammen99 merged commit 9b1a43c into master Aug 27, 2024
8 checks passed
@ammen99 ammen99 deleted the zap branch August 27, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soreau @ammen99