Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cocoapods support #105

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Remove Cocoapods support #105

merged 1 commit into from
Nov 1, 2021

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Nov 1, 2021

Swift Package Manager is the future and it turned out to no longer be easy to maintain CocoaPods support. It's not really worth the effort anymore.

Part of the reason are these kind of errors:

[09:35:20]: Pod push failed: Exit status of command 'pod trunk push' was 1 instead of 0.
[!] Found podspec `Diagnostics.podspec`
Adding spec repo `trunk` with CDN `https://cdn.cocoapods.org/`
Updating spec repo `trunk`
Validating podspec
 -> Diagnostics
 -> Diagnostics (2.0.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Build preparation complete
    - NOTE  | [iOS] xcodebuild:  note: Planning
    - NOTE  | [iOS] xcodebuild:  note: Building targets in parallel
    - NOTE  | [iOS] xcodebuild:  warning: Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the App editor. (in target 'App' from project 'App')
    - ERROR | xcodebuild:  Diagnostics/Sources/DiagnosticsReporter.swift:105:35: error: type 'Bundle' has no member 'module'
    - ERROR | xcodebuild:  Diagnostics/Sources/DiagnosticsReporter.swift:105:87: error: 'nil' requires a contextual type
    - ERROR | xcodebuild:  Diagnostics/Sources/DiagnosticsReporter.swift:112:39: error: type 'Bundle' has no member 'module'
    - ERROR | xcodebuild:  Diagnostics/Sources/DiagnosticsReporter.swift:112:94: error: 'nil' requires a contextual type

In which the Bundle.module is not available through CocoaPods. On top of that; our latest releases weren't even released through CocoaPods and we didn't get any complain.

Users will be able to either add the SPM package manually or automatically, which should be good enough.

@AvdLee AvdLee self-assigned this Nov 1, 2021
@wetransferplatform
Copy link
Collaborator

Messages
📖

View more details on Bitrise

📖 DiagnosticsTests: Executed 18 tests, with 0 failures in 0.255 seconds

Code Coverage Report

Name Coverage
Diagnostics 71.39% ⚠️

Generated by 🚫 Danger Swift against ab13bb5

@AvdLee AvdLee merged commit 7403ad5 into master Nov 1, 2021
@AvdLee AvdLee deleted the feature/remove-cocoapods branch November 1, 2021 10:56
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.1.0 🚀

Generated by GitBuddy

@alexiscreuzot
Copy link

Worst idea ever to remove support for Cocoapods...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants