Update example and readme #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikakruschel
requested review from
amirdew,
kairadiagne,
AvdLee and
BasThomas
as code owners
|
Thanks, @mikakruschel! I don't really understand, however. We (for now) went for making it optional, and that is reflected in the example. You now changed both the implementation and the example? |
|
As you can in the commit e75d7e4 and this line: you decided against making it optional. This is why the example is currently not working. All I did was to fix the example. |
|
Oh 😅, seems like I missed that. Thanks! |
BasThomas
approved these changes
Feb 17, 2022
AvdLee
approved these changes
Feb 18, 2022
Code Coverage Report
Generated by 🚫 Danger Swift against fc28bed |
|
Congratulations! 🎉 This was released as part of Release 4.0.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for making Diagnostics public, I think it's a cool way to debug apps in production.
I saw that you had a discussion about whether to use an optional array or just an empty array (e75d7e4) and decided to go the non-optional way. It seems though that you forgot to change the example, so that's what this pull request is.