Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macCatalyst support #131

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix macCatalyst support #131

merged 1 commit into from
Aug 24, 2022

Conversation

mikakruschel
Copy link
Contributor

Because CTCellularData is unavailable for macCatalyst, I added !targetEnvironment(macCatalyst) to the already existing #if os(iOS) checks.

@wetransferplatform
Copy link
Collaborator

Fails
🚫 Build service could not create build operation: internal error: could not generate PIF because the workspace has not finished loading or is still waiting for package resolution
Messages
📖

View more details on Bitrise
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 1.014 seconds

SwiftLint found issues

Severity File Reason
Warning SmartInsightsReporter.swift:51 Lines should not have trailing whitespace. (trailing_whitespace)

Code Coverage Report

Name Coverage
Diagnostics 71.81% ⚠️

Generated by 🚫 Danger Swift against b9ae403

BasThomas
BasThomas approved these changes Aug 16, 2022
View reviewed changes
Copy link

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AvdLee
Copy link
Contributor

AvdLee commented Aug 24, 2022

Thanks, this makes a lot of sense!

@AvdLee AvdLee merged commit 4e92cbb into WeTransfer:master Aug 24, 2022
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.3.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasThomas BasThomas BasThomas approved these changes

@AvdLee AvdLee AvdLee approved these changes

@amirdew amirdew Awaiting requested review from amirdew

@kairadiagne kairadiagne Awaiting requested review from kairadiagne

@raphkoebraam raphkoebraam Awaiting requested review from raphkoebraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikakruschel @wetransferplatform @AvdLee @BasThomas