Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SwiftUI previews #135

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix SwiftUI previews #135

merged 1 commit into from
Oct 31, 2022

Conversation

Rubenfer
Copy link
Contributor

Hi. Can this branch of @amirdew be merged into master to fix the annoying SwiftUI issue in previews?

SettingsError: noExecutablePath(<IDESwiftPackageStaticLibraryProductBuildable:ObjectIdentifier(0x00006000126a5cb0):'Diagnostics'>)

Thanks!

@wetransferplatform
Copy link
Collaborator

Messages
📖

View more details on Bitrise

📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 0.416 seconds

Code Coverage Report

Name Coverage
Diagnostics 71.67% ⚠️

Generated by 🚫 Danger Swift against 0272718

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, as long as there's no other way of solving SwiftUI Previews we should break them through our package.

@amirdew amirdew merged commit ee7d32a into master Oct 31, 2022
@amirdew amirdew deleted the amir-SwiftUI-patch branch October 31, 2022 08:34
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.3.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants