Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sendable conformance #146

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add Sendable conformance #146

merged 1 commit into from
Apr 24, 2023

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Apr 21, 2023

Adds Sendable conformance to our types that aren't mutable.

@wetransferplatform
Copy link
Collaborator

Messages
📖 DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.347 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.028s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.007s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.007s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 69.24% ⚠️

SwiftLint found issues

Severity File Reason
Warning HTMLGenerating.swift:72 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning DiagnosticsReporterTests.swift:93 Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
Warning DiagnosticsReporterTests.swift:58 Line should be 140 characters or less; currently it has 153 characters (line_length)
Error DiagnosticsReporterTests.swift:65 Line should be 160 characters or less; currently it has 194 characters (line_length)
Error DiagnosticsReporterTests.swift:73 Line should be 160 characters or less; currently it has 206 characters (line_length)
Warning DiagnosticsReporterTests.swift:108 Use shorthand syntax for optional binding (shorthand_optional_binding)
Warning DiagnosticsReporterTests.swift:10 Imports should be sorted (sorted_imports)

Generated by 🚫 Danger Swift against cd1c684

@AvdLee AvdLee merged commit 1945c87 into master Apr 24, 2023
@AvdLee AvdLee deleted the feature/sendable branch April 24, 2023 12:34
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.4.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants