-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS support #170
Add visionOS support #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Rubenfer!
Could you please rebase your changes on master
and remove the privacy manifest changes contained in this branch?
Thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rubenfer thanks!
It doesn't seem like the changes were rebased on master
of have master
merged in.
Could you please rebase or merge master
in this branch? That way, the privacy manifest will be included in the codebase and can be added the Package.swift
files.
Thanks in advance!
Done, @peagasilva |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going over the feedback, @Rubenfer! 🚀
Code Coverage Report
Generated by 🚫 Danger Swift against b935d47 |
@Rubenfer our repository requires signed commits. Would it be possible for you to enable signed commits and recommit them? You can do that by using the following command:
You can read more about setting up signed commits here. Thanks in advance! |
…ed keys in the given user defaults instance This is in preparation for adding the privacy manifest
…` to make it easier to identify failure
…ultsReporterTests`
Head branch was pushed to by a user without write access
b935d47
to
f8db725
Compare
This Pull Request adds visionOS support while keeping support to Swift 5.5
Fixes #162.
Note that this branch is based on the #169 PR as it should include the privacy manifest file in newly created files to support Swift 5.5.