Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS support #170

Closed
wants to merge 15 commits into from

Conversation

Rubenfer
Copy link
Contributor

This Pull Request adds visionOS support while keeping support to Swift 5.5

Fixes #162.

Note that this branch is based on the #169 PR as it should include the privacy manifest file in newly created files to support Swift 5.5.

Copy link

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@raphkoebraam raphkoebraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rubenfer!

Could you please rebase your changes on master and remove the privacy manifest changes contained in this branch?

Thanks in advance!

Copy link
Member

@raphkoebraam raphkoebraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rubenfer thanks!

It doesn't seem like the changes were rebased on master of have master merged in.

Could you please rebase or merge master in this branch? That way, the privacy manifest will be included in the codebase and can be added the Package.swift files.

Thanks in advance!

@Rubenfer
Copy link
Contributor Author

Rubenfer commented May 1, 2024

Done, @peagasilva

@Rubenfer Rubenfer requested a review from raphkoebraam May 1, 2024 15:57
Copy link
Member

@raphkoebraam raphkoebraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going over the feedback, @Rubenfer! 🚀

@wetransferplatform
Copy link
Collaborator

Messages
📖 DiagnosticsTests: Executed 35 tests (0 failed, 0 retried, 0 skipped) in 10.305 seconds
📖 Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.019s)
📖 Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.011s)
📖 Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.008s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 62.96% ⚠️

Generated by 🚫 Danger Swift against b935d47

@raphkoebraam
Copy link
Member

@Rubenfer our repository requires signed commits. Would it be possible for you to enable signed commits and recommit them? You can do that by using the following command:

 git rebase --exec 'git commit --amend --no-edit -n -S' -i develop
 git push --force

You can read more about setting up signed commits here.

Thanks in advance!

auto-merge was automatically disabled May 18, 2024 16:38

Head branch was pushed to by a user without write access

@Rubenfer Rubenfer closed this May 18, 2024
@Rubenfer Rubenfer deleted the feature/visionos-support branch May 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for visionOS
4 participants