Link to user's profile in a generated changelog #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
AvdLee,
Boris-Em and
kairadiagne
as code owners
AvdLee
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Hey Max!
Thanks for your contribution, this is great.
For my understanding, this is mostly for Changelog.md files, right?
GitHub is auto-linking from GitHub releases as you can see here.
Just want to know your thoughts behind this change 🙂
Thanks!
GitBuddyCore.framework: Coverage: 89.38
Generated by 🚫 Danger Swift against 06e02bc |
|
Hey Antoine! Yes, this change is specifically for changelogs posted outside of GitHub releases, where auto-linking doesn't work, |
|
It does, makes total sense! Merging in 🙂 |
|
Congratulations! 🎉 This was released as part of Release 2.3.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a generated changelog it would be great if usernames also linked to corresponding GitHub user profiles. The tests are modified accordingly.