Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on multiple ActiveRecord versions #62

Merged
merged 8 commits into from
Nov 3, 2021
Merged

Test on multiple ActiveRecord versions #62

merged 8 commits into from
Nov 3, 2021

Conversation

acroos
Copy link
Contributor

@acroos acroos commented Nov 3, 2021

Description

Since we recently discovered an issue with specific ActiveRecord versions, we should really increase our testing to run on all AR versions we support

Type of change

  • Improvement

How Has This Been Tested?

This change is tests!

Checklist:

  • My code follows the style guidelines set by rubocop
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@acroos acroos added the enhancement New feature or request label Nov 3, 2021
@acroos acroos self-assigned this Nov 3, 2021
@acroos acroos force-pushed the test-on-multiple-activerecord-versions branch from c13adc8 to d7fa9e3 Compare November 3, 2021 18:29
@acroos acroos merged commit 7c8e7c5 into main Nov 3, 2021
@acroos acroos deleted the test-on-multiple-activerecord-versions branch November 3, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@acroos acroos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acroos