This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Simple interface #59
Open
arnoFleming
wants to merge
18
commits into
master
Choose a base branch
from
simpler-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simple interface #59
Commits on Mar 2, 2019
-
- a Client instance can create a tranfer (and add files on the go) - split Transfers' .new and .create, - new only initializes, - create also sends it to WeTransfers' Public API - need to have a seperate add_file method to make this work - MiniIO introduced to get wrap all things IO, in a very slim interface
Configuration menu - View commit details
-
Copy full SHA for 274b4f1 - Browse repository at this point
Copy the full SHA 274b4f1View commit details -
DRYed up File and MiniIO interaction
- - DRY up request headers - NullMiniIO: all methods are empty - rename old spec files so they wont run, move them to a specific directory transform request params to JSON as late (and as once) as possible add more old spec files to the ignore list - Add RemoteFile and RemoteTransfer modules that change the corresponding instances *in place*. It sets instance variables and getter methods. - Transfer.find works, very limited test, though - Make upgrading a transfer (a bit) less magical. finalize call for transfers operational File upload implemented Implement file completion Refactorings for readability, less complexity Move communication to CommunicationHelper class More focus in integration test Expose #to_json on a transfer Refactoring * use class<<self instead of private_class_method on def self.foobar things refactor: Remove duplication remove unused image refactor get rid of useless example
Configuration menu - View commit details
-
Copy full SHA for 9ee34dc - Browse repository at this point
Copy the full SHA 9ee34dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8138841 - Browse repository at this point
Copy the full SHA 8138841View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcf0a45 - Browse repository at this point
Copy the full SHA bcf0a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 963ea55 - Browse repository at this point
Copy the full SHA 963ea55View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4b1e7b - Browse repository at this point
Copy the full SHA e4b1e7bView commit details
Commits on Mar 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 73bfb10 - Browse repository at this point
Copy the full SHA 73bfb10View commit details -
Configuration menu - View commit details
-
Copy full SHA for f272590 - Browse repository at this point
Copy the full SHA f272590View commit details
Commits on Mar 6, 2019
-
Make Communication class safer by not storing state inside some singl…
…eton Move specs around
Configuration menu - View commit details
-
Copy full SHA for 6d1f239 - Browse repository at this point
Copy the full SHA 6d1f239View commit details
Commits on Mar 7, 2019
-
small refactorings for chainging methods on a transfer, and unfuddle the :ensure_ok_status!
Configuration menu - View commit details
-
Copy full SHA for d578838 - Browse repository at this point
Copy the full SHA d578838View commit details
Commits on Mar 9, 2019
-
Document that 0.10.x only offers transfer support Document high level usage better.
Configuration menu - View commit details
-
Copy full SHA for af4eaae - Browse repository at this point
Copy the full SHA af4eaaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d0f98c - Browse repository at this point
Copy the full SHA 8d0f98cView commit details
Commits on Mar 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 30f68f9 - Browse repository at this point
Copy the full SHA 30f68f9View commit details
Commits on Mar 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ac9a7e0 - Browse repository at this point
Copy the full SHA ac9a7e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22c3bd8 - Browse repository at this point
Copy the full SHA 22c3bd8View commit details
Commits on Mar 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 789e3b3 - Browse repository at this point
Copy the full SHA 789e3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97b1443 - Browse repository at this point
Copy the full SHA 97b1443View commit details
Commits on Oct 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5541469 - Browse repository at this point
Copy the full SHA 5541469View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.