Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should parse entire magento-generated requirejs-config file #32

Closed
shakyShane opened this issue Oct 27, 2018 · 0 comments
Closed

should parse entire magento-generated requirejs-config file #32

shakyShane opened this issue Oct 27, 2018 · 0 comments

Comments

@shakyShane
Copy link
Contributor

It turned out, you cannot ask requireJS in the browser for the correct 'merged' config as it does some collapsing at run time that renders it invalid for the build process (eg: dropping some top-level 'deps')

Instead, just parse the entire file pulling out only the config
shakyShane added a commit that referenced this issue Oct 27, 2018
@shakyShane
Merge pull request #33 from WeareJH/config-parse
703afb5 
fix: parse the entire requirejs-config.js file - fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shakyShane